Fix communications with localhost only <2.0.x> [9744]#1520
Merged
MiguelCompany merged 10 commits into2.0.xfrom Oct 28, 2020
Merged
Fix communications with localhost only <2.0.x> [9744]#1520MiguelCompany merged 10 commits into2.0.xfrom
MiguelCompany merged 10 commits into2.0.xfrom
Conversation
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…aces. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
46cd368 to
f6a8694
Compare
Member
|
Could you write a regression test using test_UDPv4Transport? This implies implementing a new feature in test_UDPv4Transport: be able to return zero interfaces to Fast-DDS. |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
0e8bd60 to
597df9a
Compare
richiware
approved these changes
Oct 27, 2020
Member
|
Build status:
|
Member
Author
|
Failures seem unrelated |
This was referenced Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue reported on ros2/ros2#1052
Multicast was not correctly being sent through localhost interface when no network interface was detected. This PR changes the mechanism from adding a localhost initial peer to binding the outbound socket to the local interface.