Skip to content

[22056] Transform locators using new host_id PID#106

Closed
cferreiragonz wants to merge 2 commits intomasterfrom
feature/add_host_id_to_dataP
Closed

[22056] Transform locators using new host_id PID#106
cferreiragonz wants to merge 2 commits intomasterfrom
feature/add_host_id_to_dataP

Conversation

@cferreiragonz
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz commented Nov 4, 2024

Description

This PR includes a test for a bug in which a TCP client connecting to localhost is unable to identify the locator of a TCP discovery server with a custom GUID listening on any.
Depends on:

@Mergifyio backport 1.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • Changes are backwards compatible.
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v2.0.1 milestone Nov 4, 2024
@cferreiragonz cferreiragonz changed the title [22006] Host_id transform_locators test [22006] Transform locators using new host_id PID Nov 4, 2024
@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label Nov 5, 2024
@cferreiragonz cferreiragonz changed the title [22006] Transform locators using new host_id PID [22056] Transform locators using new host_id PID Nov 5, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the feature/add_host_id_to_dataP branch from 274125e to 1deed68 Compare November 5, 2024 08:51
@MiguelCompany MiguelCompany self-requested a review November 6, 2024 11:45
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz deleted the feature/add_host_id_to_dataP branch November 6, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending needs-review PR that is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants