Skip to content

Add german translations#319

Merged
davideicardi merged 1 commit intodynamicexpresso:masterfrom
cpiber:master
Oct 29, 2024
Merged

Add german translations#319
davideicardi merged 1 commit intodynamicexpresso:masterfrom
cpiber:master

Conversation

@cpiber
Copy link
Copy Markdown
Contributor

@cpiber cpiber commented Sep 10, 2024

This PR adds German translations

It seems like it's not possible to create translations for an external assembly using ResourceManager, and we need the errors in German.
I noticed this localization was added in #36, if @davideicardi or @jasonhumberstone know how I could provide translations from my project I would also be open to that.

If you ever need updates for the translations feel free to ping me.
I based the translations based on my understanding (mother tongue) and Microsoft's documentation translation.

@davideicardi
Copy link
Copy Markdown
Member

Thank you!
I don't see problems adding translations here.

Can you just check what happen if for some reason one translation is missing? I don't remember the default behavior ...

@cpiber
Copy link
Copy Markdown
Contributor Author

cpiber commented Sep 10, 2024

The default behavior is to fall back to the fallback resource (no language identifier), in this case English

@cpiber
Copy link
Copy Markdown
Contributor Author

cpiber commented Oct 29, 2024

Any plans for a new version with the localization included?

@davideicardi davideicardi merged commit 590910d into dynamicexpresso:master Oct 29, 2024
@davideicardi
Copy link
Copy Markdown
Member

Just released 2.17.1 ! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants