Merged
Conversation
davideicardi
approved these changes
Aug 19, 2024
Member
davideicardi
left a comment
There was a problem hiding this comment.
Completely agree! The Parser class is very old and was never refactored. Thank you!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Parser.csclass is huge, which prevents code reuse: for example, we could imagine reuse the resolution logic in the late binders for dynamic objects.In any case, having smaller files should make the code easier to understand. Let me know what you think :)
The PR has been split into several smaller commits to make it easier to review (and to validate each step).