No longer move to the next token when parsing an is or as expression#289
Merged
metoule merged 4 commits intodynamicexpresso:masterfrom Jun 11, 2023
Merged
No longer move to the next token when parsing an is or as expression#289metoule merged 4 commits intodynamicexpresso:masterfrom
is or as expression#289metoule merged 4 commits intodynamicexpresso:masterfrom
Conversation
metoule
commented
Jun 10, 2023
metoule
commented
Jun 10, 2023
davideicardi
approved these changes
Jun 10, 2023
Member
davideicardi
left a comment
There was a problem hiding this comment.
Great PR as usual! Thank you!
Maybe you can just add as test the case 'string.IsNullOrEmpty(variable as string))'?
The one mentioned in the bug...
Contributor
Author
|
Good idea, I've added the test for the case mentioned in the bug report |
davideicardi
approved these changes
Jun 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes introduced in #178, the parser no longer needs to move to the token after the known type.
Fixes #287