Adding fuller support for resolving anonymous type data on a dynamic object#258
Merged
metoule merged 6 commits intodynamicexpresso:masterfrom Sep 26, 2022
Merged
Conversation
added 3 commits
September 20, 2022 11:00
…CallSiteBinding the same way as compiled code.
metoule
reviewed
Sep 21, 2022
Contributor
metoule
left a comment
There was a problem hiding this comment.
I have a few minor nitpicking comments, but otherwise it looks good to me, thanks a lot!
Contributor
|
LGTM, thanks again for all your contributions! |
davideicardi
approved these changes
Sep 26, 2022
Member
davideicardi
left a comment
There was a problem hiding this comment.
LGTM! Very nice improvements!
Thank you @holdenmai !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #93
The major change made with this is that rather than performing the binding, somewhat greedily, on typeof(object), we leverage the actual instance present in the CallSiteBinder args parameter to get the actual type as late as possible.