Allow default values for generic parameters#239
Merged
davideicardi merged 1 commit intodynamicexpresso:masterfrom Jun 14, 2022
Merged
Allow default values for generic parameters#239davideicardi merged 1 commit intodynamicexpresso:masterfrom
davideicardi merged 1 commit intodynamicexpresso:masterfrom
Conversation
metoule
reviewed
Jun 10, 2022
metoule
requested changes
Jun 10, 2022
Contributor
metoule
left a comment
There was a problem hiding this comment.
It looks good, but I'd add the following test to be sure:
public List<T> MethodWithGenericParamAndDefault<T>(T a, List<T> b = default)
{
return b;
}
var b = MethodWithGenericParamAndDefault(1);
Assert.Null(b);
generalize default expressions for generic methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public T MethodWithGenericParamAndDefault<T>(T a, T b = default) { return a; }The above method throws when parameter b is not set. This PR does a best effort in searching for a previously specified parameter of the same type to construct the default expression for this case.
When invoking
MethodWithGenericParamAndDefault(1)it uses the knowledge the paramahas the same type int asb.