@tatchi Nice!!! I'll review this soon, I'm super excited to up the OCaml version.

EDIT: I think I know which test is failing --- see the fix I implemented for #89 . Those changes are not upstream in css-parser, so using that as a dependency is breaking the test. I'll try to get the upstream PR merged in ASAP so a new version of css-parser can be published.

EDIT: I think I know which test is failing --- see the fix I implemented for #89 . Those changes are not upstream in css-parser, so using that as a dependency is breaking the test. I'll try to get the upstream PR merged in ASAP so a new version of css-parser can be published.

Cool, let's wait for a new release of css-parser then :)

@dylanirlbeck I bumped css-parser to the latest version 0.2.4 but the test still fails... Do you have any idea what might be the cause?

I think the error comes from the comparison of the Location.Error exception. For now I changed the assertion to just make sure that an exception is thrown.

@dylanirlbeck it builds now on windows but CI fails at a later stage: Get Esy UsePpx binary path. Any idea what might go wrong here?

@tatchi Hmm I'm a bit lost on this one, especially because the test passes on Linux/Mac. I'll continue to investigate.. sorry for the delay on this, just started a new job haha

@tatchi So I'm still stuck on this, and have posted on Discord in hopes of getting a response. What causes even more confusion is the fact that the same test passes in this PR, with the only difference between the two PRs being yours changes the OCaml version.

I'm very much confused.. as a sanity check you could drop the esy version on CI to 0.6.2 and see what happens? It might be worth a shot.

@tatchi See esy/esy#1096 (comment). Can you try the fix proposed in the comments by Manas?

@dylanirlbeck looks like it fixes the issue :)

@tatchi 🔥 🔥 🔥

I'm going to double-check to see if a new esy version is on the horizon, since I'm not sure if using the nightly build is super reliable -- just hang tight, I'll merge this in either way by the end of the week.

@tatchi 🔥 🔥 🔥

I'm going to double-check to see if a new esy version is on the horizon, since I'm not sure if using the nightly build is super reliable -- just hang tight, I'll merge this in either way by the end of the week.

Nice :) Not sure what are you plan about #100 but once this one is merged, I can rebase #100 and there won't be any needs for nightly version of esy

@dylanirlbeck esy 0.6.5 was just released so I switched back to the latest version (not the nightly one). I guess it should be ok :)