This repository was archived by the owner on Aug 17, 2021. It is now read-only.
tolerate multiple class definitions on same line#85
Merged
dylanirlbeck merged 3 commits intodylanirlbeck:masterfrom May 13, 2020
Merged
tolerate multiple class definitions on same line#85dylanirlbeck merged 3 commits intodylanirlbeck:masterfrom
dylanirlbeck merged 3 commits intodylanirlbeck:masterfrom
Conversation
dylanirlbeck
approved these changes
May 13, 2020
Owner
dylanirlbeck
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the PR 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this ppx with bucklescript-tea and ocamlformat with ocaml syntax, I hit an issue where the regex is too greedy and ends up parsing classes like
"p-6\"]></div>",when multiple appear on the same line. For instance, Ocamlformat ends up formatting lines with ternaries on a single line: