Skip to content

Cherry-pick fix for ASA-2025-002#40

Merged
roy-dydx merged 2 commits intodydx-fork-v0.38.5from
roy/ASA-2025-002
Feb 3, 2025
Merged

Cherry-pick fix for ASA-2025-002#40
roy-dydx merged 2 commits intodydx-fork-v0.38.5from
roy/ASA-2025-002

Conversation

@roy-dydx
Copy link

@roy-dydx roy-dydx commented Feb 3, 2025

Cherry-picked fix for ASA-2025-002: 415c0da
Additionally commits included:

1f48ff9

mergify bot and others added 2 commits February 3, 2025 11:17
…ocks (backport cometbft#1408) (cometbft#2139)

This is an automatic backport of pull request cometbft#1408 done by
[Mergify](https://mergify.com).
Cherry-pick of 28ad4d2 has failed:
```
On branch mergify/bp/v0.38.x/pr-1408
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit 28ad4d2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   consensus/state.go
	modified:   consensus/state_test.go
	modified:   crypto/merkle/proof.go
	modified:   evidence/pool_test.go
	modified:   state/execution_test.go
	modified:   types/event_bus_test.go
	modified:   types/part_set.go
	modified:   types/part_set_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   internal/consensus/errors.go
	both modified:   state/store_test.go
	both modified:   store/store_test.go

```


To fix up this pull request, you can check it out locally. See
documentation:
https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

---------

Co-authored-by: Daniel <daniel.cason@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
@teddyding
Copy link

In PR summary, why is 38a4cae relevant?

@roy-dydx
Copy link
Author

roy-dydx commented Feb 3, 2025

good catch, bad copy paste

@roy-dydx roy-dydx merged commit 3ab07f4 into dydx-fork-v0.38.5 Feb 3, 2025
14 of 15 checks passed
@roy-dydx roy-dydx deleted the roy/ASA-2025-002 branch February 3, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants