fix: upgrade reqwest to 0.13 with native CA cert support for non-Windows#1
Merged
Merged
Conversation
Co-authored-by: dwhoban <5687870+dwhoban@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update reqwest and ensure config allows loading local CA certs
fix: upgrade reqwest to 0.13 with native CA cert support for non-Windows
Mar 20, 2026
dwhoban
approved these changes
Mar 20, 2026
There was a problem hiding this comment.
Pull request overview
Upgrades the workspace’s HTTP stack to reqwest 0.13 and adjusts non-Windows TLS configuration so vp install can trust enterprise / system-installed CA certificates (e.g., MITM proxies in WSL2) by using native trust stores.
Changes:
- Bump workspace
reqwestdependency from0.12→0.13. - On non-Windows targets, switch
reqwestTLS feature flags fromrustls-tlstorustls+rustls-native-certsin affected crates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updates the workspace reqwest version to 0.13. |
| crates/vite_install/Cargo.toml | Switches non-Windows reqwest TLS features to use native certs. |
| crates/vite_error/Cargo.toml | Switches non-Windows reqwest TLS features to use native certs. |
| crates/vite_js_runtime/Cargo.toml | Switches non-Windows reqwest TLS features to use native certs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dan Hoban <5687870+dwhoban@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp installfails behind MITM proxies (e.g., Zscaler in WSL2) because reqwest 0.12 withrustls-tlsuses only Mozilla's bundled WebPKI roots — ignoring system-installed CA certificates entirely.Changes
Cargo.toml: Bumpreqwestworkspace dependency0.12→0.13crates/vite_install,vite_error,vite_js_runtime: On non-Windows, replacerustls-tlswithrustls+rustls-native-certsrustls-native-certsloads from the OS trust store (e.g.,/etc/ssl/certs/ca-certificates.crton Debian/Ubuntu, Keychain on macOS), so enterprise CAs installed by proxy tools are automatically trusted. Windows already usednative-tls-vendoredwhich reads from the system store and is unchanged.Note: reqwest 0.13 renamed the TLS feature flags —
rustls-tlsno longer exists; the equivalent is nowrustls+ an explicit roots feature (rustls-native-certsorwebpki-roots).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.