Conversation
Petit oubli de f-string logging. J'ai vu passer quelques erreurs dans mes logs pour ces fonctions-là qui peuvent être réglés avec un peu de défensive. Vient du race condition que j'ai du créer avec le device list.
Ne fera pas de key error si le challenge list l'a déjà flushé
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit oubli de f-string logging.
J'ai vu passer quelques erreurs dans mes logs pour ces fonctions-là qui peuvent être réglés avec un peu de défensive.
Vient du race condition que j'ai du créer avec le device list. Empêche une erreur si on tente de rouler ce code avant que tout soit starté.