Conversation
Add await pour la fonction qui check la mise en cache locale du devicelist.
Enlevé doublons, on callait subscribe to location dans les challenge, et les challenge aussi.
Move this after websocket connects, else we would time out before they started.
Missing docstrings to make mypy happy
Bump up versions
Plus de commentaires pour expliquer ce qu'on fait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
J'avais mal compris la portée de l'issue #564 et n'avait pas complété le travail que Abigail avait commencé, AKA: j'me suis mis dans la marde.
On faisait toujours un GET via REST au devicelist pour générer.
Ce PR permet de passer vers le devicehub pour la même device list, car le endpoint est très beaucoup en fin de vie.
Depends on dvd-dev/python-hilo#389