Merged
Conversation
At the moment, py-setproctitle cannot be compiled using Visual Studio, which complains about a certain static variable initialization. This simple patch updates this initialization, allowing the project to be compiled successfully: http://paste.openstack.org/raw/800734/ Closes: dvarrazzo#89 Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Owner
|
Thank you very much for this contribution! 💜 |
Owner
|
Have you noticed the warnings? Are them anything to worry about? |
dvarrazzo
reviewed
Dec 4, 2020
Contributor
Author
Those are being redefined, it doesn't affect the build though. I think the |
dvarrazzo
reviewed
Dec 4, 2020
dvarrazzo
reviewed
Dec 4, 2020
dvarrazzo
reviewed
Dec 4, 2020
On Windows, "environ" is a macro that expands to __p__environ [1], which is an array of strings. This commit will avoid redefining it. https://docs.microsoft.com/en-us/cpp/c-runtime-library/environ-wenviron?view=msvc-160 Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
This patch will add a few simple Windows setproctitle tests. The existing ones are Linux specific, so we're going to add a new file while using module-level platform checks. Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
1f7beeb to
0f46dfd
Compare
This commit adds Github workflows for building the Windows wheels and running the tests. Related issue: dvarrazzo#47 Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
0f46dfd to
a9f50c2
Compare
Contributor
Author
|
@dvarrazzo Thanks for feedback. I've added x86 packages as well as some tests. Please let me know if there's anything else that I should add. |
Owner
|
Hi @petrutlucian94 thank you very much for your contribution! I will try to review and merge the branch as soon as I have time, in the next days. Very appreciated, thank you :) |
Owner
|
Merged to master, thank you very much! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows build
At the moment, py-setproctitle cannot be compiled using Visual
Studio, which complains about a certain static variable initialization.
This PR updates this initialization, allowing the project
to be compiled successfully: http://paste.openstack.org/raw/800734/
At the same time, we're providing GitHub actions that will take care
of building Windows Python wheels.
Closes: #89
Related issue: #47
Signed-off-by: Lucian Petrut lpetrut@cloudbasesolutions.com