bootupd: small tweaks and initial tests#14
Merged
dustymabe merged 3 commits intodustymabe:dusty-bootupdfrom Jan 9, 2024
Merged
bootupd: small tweaks and initial tests#14dustymabe merged 3 commits intodustymabe:dusty-bootupdfrom
dustymabe merged 3 commits intodustymabe:dusty-bootupdfrom
Conversation
dustymabe
reviewed
Jan 9, 2024
stages/test/test_bootupd.py
Outdated
| ({"deployment": {"ref": "some-ref"}}, "'osname' is a required property"), | ||
| ({"deployment": {"osname": "some-os", "ref": "some-ref", "serial": "must-be-number"}}, | ||
| "'must-be-number' is not of type 'number'"), | ||
| ({"random": "propertey"}, "Additional properties are not allowed"), |
Owner
There was a problem hiding this comment.
Suggested change
| ({"random": "propertey"}, "Additional properties are not allowed"), | |
| ({"random": "property"}, "Additional properties are not allowed"), |
mispelling here intentional?
| os.path.join(root, mnt)], | ||
| check=True) | ||
| try: | ||
| with bind_mounts(['/dev', '/proc', '/sys', '/run', '/var', '/tmp'], root): |
Owner
There was a problem hiding this comment.
Suggested change
| with bind_mounts(['/dev', '/proc', '/sys', '/run', '/var', '/tmp'], root): | |
| with bind_mounts(['dev', 'proc', 'sys', 'run', 'var', 'tmp'], root): |
Feels a bit weird to have the / in the specified mounts here but then just `lstrip("/") them off for each use.. Is that just the desire to be as explicit as possible that they are a toplevel mount?
Author
There was a problem hiding this comment.
I can remove this again but yeah, the intention was to make it very explicit that it's toplevel
Owner
There was a problem hiding this comment.
It's fine as is, I just wanted to understand more.
1ceca8a to
acb5466
Compare
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.