fix accessing real example.com in test cases#252
Merged
AaronAtDuo merged 1 commit intoduosecurity:masterfrom Feb 14, 2024
Merged
fix accessing real example.com in test cases#252AaronAtDuo merged 1 commit intoduosecurity:masterfrom
AaronAtDuo merged 1 commit intoduosecurity:masterfrom
Conversation
jeffreyparker
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove ssl certificate test failure bug - no longer accessing the real example.com
Description
Factor out the code that causes the issue into a function and mock that function in the test cases. Also, remove the temporary workaround.
Motivation and Context
https://cisco-sbg.atlassian.net/browse/ZTMSP-771
context: https://duosecurity.slack.com/archives/CJCHMJDL7/p1707334317810179
How Has This Been Tested?
ran nose2 with and without the changes in base.py - without the mocks (and the temporary workaround has been removed) 5 test cases fail. They pass with the mock.
Types of Changes