Skip to content

Move nft tokens metadata to tokens subproject#6034

Merged
jeff-dude merged 17 commits into
mainfrom
tokens-nft
May 31, 2024
Merged

Move nft tokens metadata to tokens subproject#6034
jeff-dude merged 17 commits into
mainfrom
tokens-nft

Conversation

@aalan3

@aalan3 aalan3 commented May 30, 2024

Copy link
Copy Markdown
Contributor

This PR moves the existing tokens.nft lineage to the tokens subproject. Solana tokens are not moved for now. This is in preparation for moving the contract mappings lineage

@aalan3 aalan3 requested review from 0xRobin, couralex6 and jeff-dude May 30, 2024 10:40
END as aggregator_name
FROM {{base_trades}} base
LEFT JOIN {{ref('tokens_nft')}} nft
LEFT JOIN {{source('tokens', 'nft')}} nft

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @0xRobin
we are looking to move nft token metadata to tokens subproject, similar to erc20, flipping to source is part of that

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this one may be backwards?
all of these edition metadata spells should be moved to tokens subproject as they are dependencies for tokens_nft lineage. otherwise we create circular dependencies?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt ls --resource-type model --output name --select decent_optimism_edition_metadata+1
dbt ls --resource-type model --output name --select +decent_optimism_edition_metadata

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing upstream, only token metadata downstream

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are right I can move this to the tokens subproject

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be deleted?

@aalan3 aalan3 requested a review from jeff-dude May 30, 2024 17:41

@jeff-dude jeff-dude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running with modified turned off in prod for both projects

@jeff-dude jeff-dude merged commit f62a25b into main May 31, 2024
@jeff-dude jeff-dude deleted the tokens-nft branch May 31, 2024 15:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants