Update ThemeWindowManagerFactory.java#6
Merged
Merged
Conversation
Provides more robust handling for different Operating Systems and their major versions.
Contributor
Author
|
@dukke Please review PR. |
Owner
|
This PR makes a nice tweak to the way we return the appropriate ThemeWindowManager... I just left some minor change suggestion, can you check please? |
dukke
requested changes
Jul 20, 2024
Added error message for major version.
Owner
|
Merged. |
Contributor
Author
|
Awesome! Thanks for merging that @dukke. 😁 Any idea when this will be pushed to the Maven repo? You might also want to update the version in the README for the maven repo as well. There's probably a way to automate it, I'm just not sure how. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides more robust handling for different Operating Systems and their major versions.