Treat MinGW as a different platform for extension loading purposes#7007
Merged
Mytherin merged 1 commit intoduckdb:masterfrom Apr 8, 2023
Merged
Treat MinGW as a different platform for extension loading purposes#7007Mytherin merged 1 commit intoduckdb:masterfrom
Mytherin merged 1 commit intoduckdb:masterfrom
Conversation
2 tasks
Contributor
|
We probably need to add something similar for musl and Android, right? |
Collaborator
Author
|
Possibly yes. For Linux we might be able to make a universal build by statically linking musl instead, which can then also be used by people with a low glibc version. |
|
when to support MinGW ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6231
This PR makes it so that MinGW is treated as a different platform for extension installation/loading purposes. This should make it so MinGW users no longer load extensions compiled with Visual Studio which causes crashes. This is primarily a problem for R on Windows because the R toolchain uses MinGW internally.
This PR does not yet set up the infrastructure to compile & upload extensions for MinGW, however, so the extensions will not yet be available to install for MinGW users. Instead trying to install a MinGW extension should now result in an "extension not found" error.