Rework Order Dependence Tracking in Pipelines#7006
Merged
Mytherin merged 8 commits intoduckdb:masterfrom Apr 10, 2023
Merged
Conversation
lnkuiper
approved these changes
Apr 8, 2023
Collaborator
lnkuiper
left a comment
There was a problem hiding this comment.
Good idea to distinguish between insertion order and the fixed order that an operator should return data in! LGTM
| bool IsOrderPreserving() const override { | ||
| return true; | ||
| OrderPreservationType SourceOrder() const override { | ||
| return OrderPreservationType::NO_ORDER; |
Collaborator
There was a problem hiding this comment.
PhysicalWindow does not have batch indices, but maybe it should?
Not something to fix in this PR, but it would be nice to guarantee that the result of a window is returned with the groups together, and in order, and then this can be changed to FIXED_ORDER.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks how order-dependence of operators are tracked in pipelines - specifically, it adds an enum
OrderPreservationTypethat tracks in which way operators emit/preserve order:The goal of this is to distinguish between operators that merely emit or maintain insertion order (e.g. table scans), and operators that emit a fixed order that must be maintained (e.g. ORDER BY, top-n). This fixes an issue found by @pdet (and also encountered in the test suite when increasing parallelism of aggregate scans) where
ORDER BYinformation was incorrectly lost whenpreserve_insertion_orderwas set to false.In addition in this PR we create separate more clear methods for order dependence depending on the stage of the operator:
SinkOrderDependent,OperatorOrderandSourceOrder.