Merged
Conversation
update or replace Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Collaborator
|
Thanks! Looks great. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug in the anti semi join logic when complex conditions are used.
When complex conditions are used (i.e (a IS NULL AND b IS NULL) OR (a = b)), a cross product is created and the condition is checked on the cross product. Thankfully the cross product is preformed by scanning the tuples of the smaller table, creating constant vectors, then attaching them with the columns of the larger table. Depending on which table is smaller (in cardinality), we figure out which tuples from the LHS need to be put into the result