Wiring storage_info into attach and create_transaction_manager calls#6161
Merged
Mytherin merged 5 commits intoduckdb:masterfrom Feb 10, 2023
Merged
Conversation
Collaborator
|
Thanks! The remaining issue here is that the SQLite extension relies on these functions as well. The way we handle that conflict is by first patching the SQLite extension, and then updating the git hash that is referenced in |
Mytherin
reviewed
Feb 9, 2023
| typedef unique_ptr<Catalog> (*attach_function_t)(AttachedDatabase &db, const string &name, AttachInfo &info, | ||
| AccessMode access_mode); | ||
| typedef unique_ptr<TransactionManager> (*create_transaction_manager_t)(AttachedDatabase &db, Catalog &catalog); | ||
| typedef unique_ptr<Catalog> (*attach_function_t)(StorageExtensionInfo &storage_info, AttachedDatabase &db, |
Collaborator
There was a problem hiding this comment.
As the StorageExtensionInfo is optional - perhaps we can make this a pointer instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.