Skip to content

Add relational tests back#6038

Merged
hannes merged 9 commits intoduckdb:masterfrom
Tmonster:add-relational-tests-back
Feb 6, 2023
Merged

Add relational tests back#6038
hannes merged 9 commits intoduckdb:masterfrom
Tmonster:add-relational-tests-back

Conversation

@Tmonster
Copy link
Contributor

To get CI passing, we took out some relational tests. Looked into the issue and I think I've solved it so that we can run test_relational.R once again.

@krlmlr, @hannes any guesses as to why this error is appearing now?

@Tmonster Tmonster requested review from carlopi, hannes and krlmlr January 30, 2023 13:52
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to give any feedback on this

@krlmlr
Copy link
Contributor

krlmlr commented Jan 31, 2023

Not sure why we need to do that much. Tests seem to pass if we only remove the skip() call?

To run an individual test file, use:

testthat::test_local(filter = "^relational$")

@krlmlr
Copy link
Contributor

krlmlr commented Jan 31, 2023

I was mistaken: we can remove the skip() call on the latest version of your branches combined. But we could do that separately, I still don't think changing the tests should be necessary at all.

@Tmonster
Copy link
Contributor Author

@krlmlr I don't want to change the tests, but without the change in this PR (i.e as.data.frame.duckdb_relation) we continue to get the following error during CI. Do you have an idea as to why this is?

image

@krlmlr
Copy link
Contributor

krlmlr commented Jan 31, 2023

I've seen this too in #6048, but not when applying to your latest WIP PRs. Maybe it's worth enabling the tests in one of those?

@Tmonster
Copy link
Contributor Author

Tmonster commented Feb 1, 2023

The error happens in CI or when you run the tests on an ubuntu image. I can't recreate the error locally either. It makes me think that there has been some update somewhere in the dependencies where we now have to specify the extra .duckdb_relation

@hannes hannes merged commit 01a87da into duckdb:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants