Skip to content

Python: Allow replacement scans on pyrelations, move to BoxRenderer and use pending query API for relations#5962

Merged
Mytherin merged 11 commits intoduckdb:masterfrom
Mytherin:pythonimprovements
Jan 24, 2023
Merged

Python: Allow replacement scans on pyrelations, move to BoxRenderer and use pending query API for relations#5962
Mytherin merged 11 commits intoduckdb:masterfrom
Mytherin:pythonimprovements

Conversation

@Mytherin
Copy link
Collaborator

@Mytherin Mytherin commented Jan 23, 2023

This PR makes several improvements to the Python Relational API:

  • Move to BoxRenderer for relation objects
  • Allows querying relation objects using replacement scans, e.g. this now works:
lineitem = duckdb.query('from lineitem.parquet');
res = duckdb.query('select l_returnflag, sum(l_extendedprice) from lineitem group by all')
print(res)
┌──────────────┬──────────────────────┐
│ l_returnflag │ sum(l_extendedprice) │
│   varchar    │    decimal(38,2)     │
├──────────────┼──────────────────────┤
│ A            │       56586554400.73 │
│ N            │      116422715119.57 │
│ R            │       56568041380.90 │
└──────────────┴──────────────────────┘
  • Move to using pending query results, so execution of relations can be interrupted
  • Add a cache for the str representation of relation objects

@Mytherin Mytherin requested a review from Tishj January 23, 2023 08:53
Mause
Mause suggested changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@Mause Mause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks 😅

@Mytherin @Mause
Apply suggestions from code review
5085477 
Thanks @Mause

Co-authored-by: Elliana May <me@mause.me>
Tishj
Tishj reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@Tishj Tishj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great piece of functionality and seems like this was relatively low hanging fruit.
That being said it was invisible to me haha

I had one final comment regarding the removal of the GIL unlock to print the progress bar.
Sadly we dont/cant have Jupyter tests, I'm curious if this might break something there

src/main/materialized_query_result.cpp
if (!success) {
return GetError() + "\n";
}
if (!collection) {
Copy link
Contributor

@Tishj Tishj Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want to throw an exception here instead?

Copy link
Collaborator Author

@Mytherin Mytherin Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general results should not throw exceptions because they might be used in places where those are unexpected.

@Mytherin Mytherin merged commit b7b7ea6 into duckdb:master Jan 24, 2023
@Mytherin Mytherin deleted the pythonimprovements branch February 16, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Tishj Tishj Tishj left review comments

@Mause Mause Mause requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mytherin @Mause @Tishj