add appender to concurrent test#18721
Merged
hannes merged 17 commits intoduckdb:v1.3-ossivalisfrom Sep 3, 2025
Merged
Conversation
Contributor
|
See void append(Connection &conn, idx_t i) {
lock_guard<mutex> lock(dbInfos[i].mu);
auto maxTblId = dbInfos[i].appendTableCount;
if (maxTblId == 0) {
return;
} |
Contributor
taniabogatsch
left a comment
There was a problem hiding this comment.
Hi @c-herrewijn, thanks for your work on this!! I've left some comments. :)
Comment on lines
247
to
248
| // execQuery(initConn, "SET default_block_size = '16384'"); | ||
| // execQuery(initConn, "SET storage_compatibility_version = 'v1.3.2'"); |
Contributor
There was a problem hiding this comment.
can we add a fast test with these settings, too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update testcase to also take into account data storage via the appender.