Fix map_extract backwards compatability#15799
Merged
Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom Jan 20, 2025
Merged
Fix map_extract backwards compatability#15799Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom
Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up from #14175 that changed the return value of
map_extractandelement_atto return a single value from maps by key instead of a list with the value.This is a good change, but unfortunately It breaks backwards/forwards compatibility for serialized query plans. This PR fixes it by reverting the change to
map_extractbut instead add a newmap_extract_valuewith the new behavior. It also changes the syntax sugar (e.g.[]) to use this new function instead, so the end user still "mostly" sees the new behavior, while the system internally still keeps the same behavior for the actual function.