Fix some memory/storage issues in CI#15795
Merged
Mytherin merged 1 commit intoduckdb:v1.2-histrionicusfrom Jan 20, 2025
Merged
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests
Were giving memory/storage issues in CI.
For (1.), I've reduced the TPC-H scale factor to 0.1 instead of 1. We're still testing what we want to test, so this shouldn't be an issue (TPC-H files are really large when exported to JSON).
For (2.), the setting
PRAGMA verify_external;was triggering a lot of partitioning and spilling to test the external grouped aggregation behavior. It was spilling more than necessary because the HT size calculation was off a bit, especially when this setting was enabled.For (3.), a slight increase to the memory limit in the test was enough to make it work again. We're still testing the behavior we want to.