Merged
Conversation
dtolnay
approved these changes
Oct 30, 2025
| let (name, extension) = filename | ||
| .rsplit_once('.') | ||
| .expect("Failed to split file name into name and extension"); | ||
| let re = Regex::new(&format!(r"# {name}-(\d+).(\d+).(\d+).{extension}")).unwrap(); |
Owner
There was a problem hiding this comment.
Suggested change
| let re = Regex::new(&format!(r"# {name}-(\d+).(\d+).(\d+).{extension}")).unwrap(); | |
| let re = Regex::new(&format!(r"# {name}-(\d+)\.(\d+)\.(\d+)\.{extension}")).unwrap(); |
Comment on lines
+92
to
+102
| let v = caps | ||
| .iter() | ||
| .skip(1) | ||
| .map(|s| { | ||
| s.unwrap() | ||
| .as_str() | ||
| .parse() | ||
| .expect("Failed to parse unicode version") | ||
| }) | ||
| .collect::<Vec<u64>>(); | ||
| (v[0], v[1], v[2]) |
Owner
There was a problem hiding this comment.
Some APIs that make this neater:
- https://docs.rs/regex/1.12.2/regex/struct.Captures.html#method.extract
- https://doc.rust-lang.org/std/primitive.array.html#method.map
- https://doc.rust-lang.org/std/primitive.array.html#impl-From%3C%5BT;+1%5D%3E-for-(T,)
Suggested change
| let v = caps | |
| .iter() | |
| .skip(1) | |
| .map(|s| { | |
| s.unwrap() | |
| .as_str() | |
| .parse() | |
| .expect("Failed to parse unicode version") | |
| }) | |
| .collect::<Vec<u64>>(); | |
| (v[0], v[1], v[2]) | |
| let (_, [major, minor, patch]) = caps.extract(); | |
| [major, minor, patch] | |
| .map(|s| s.parse().expect("Failed to parse unicode version")) | |
| .into() |
Contributor
Author
|
Thanks for merging and for the suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this PR adds the exposed
UNICODE_VERSIONconst.This brings complete feature parity with
unicode-xid.Thanks!