Touch up PR 305

dtolnay · dtolnay · commit a6fc23bbdecb · 2025-05-12T01:20:35.000+02:00
diff --git a/src/rustflags.rs b/src/rustflags.rs
@@ -8,10 +8,9 @@ pub(crate) fn toml() -> toml::Value {
         rustflags.push(lint);
     }
 
-    if let Some(flags) = std::env::var("RUSTFLAGS").ok() {
-        // TODO: could parse this properly and allowlist (or blocklist?)
-        // certain flags. This is good enough to at least support
-        // `cargo-llvm-cov`.
+    if let Ok(flags) = std::env::var("RUSTFLAGS") {
+        // TODO: could parse this properly and allowlist or blocklist certain
+        // flags. This is good enough to at least support cargo-llvm-cov.
         if flags.contains("-C instrument-coverage") {
             rustflags.extend(["-C", "instrument-coverage"]);
         }

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,9 @@ pub(crate) fn toml() -> toml::Value {`
`8`	`8`	`rustflags.push(lint);`
`9`	`9`	`}`
`10`	`10`
`11`		`- if let Some(flags) = std::env::var("RUSTFLAGS").ok() {`
`12`		`- // TODO: could parse this properly and allowlist (or blocklist?)`
`13`		`- // certain flags. This is good enough to at least support`
`14`		- // `cargo-llvm-cov`.
	`11`	`+ if let Ok(flags) = std::env::var("RUSTFLAGS") {`
	`12`	`+ // TODO: could parse this properly and allowlist or blocklist certain`
	`13`	`+ // flags. This is good enough to at least support cargo-llvm-cov.`
`15`	`14`	`if flags.contains("-C instrument-coverage") {`
`16`	`15`	`rustflags.extend(["-C", "instrument-coverage"]);`
`17`	`16`	`}`