Skip to content

New release breaks callers of the Error derive if it came from a re-export from another crate #241

@NiseVoid

Description

@NiseVoid

Hello, the new release of thiserror seems to have broken something. A game engine called bevy re-exports thiserror in a bevy_utils crate, when the code is then called in other places it fails to compile on the newest release because it calls thiserror::__private when the path it is available at would be bevy_utils::thiserror::_private. This results in compilation errors, for example this CI run: https://github.com/Jondolf/bevy_xpbd/actions/runs/5481101314/jobs/9985014733#step:4:293
I'm not quite sure what the correct solution here is, but I think calling the macros from a re-export is a valid usecase that should work as intended

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions