Skip to content

Allow lifetimes in function pointer return values#1847

Merged
dtolnay merged 1 commit intomasterfrom
lifetimes
Feb 2, 2025
Merged

Allow lifetimes in function pointer return values#1847
dtolnay merged 1 commit intomasterfrom
lifetimes

Conversation

@dtolnay
Copy link
Copy Markdown
Owner

@dtolnay dtolnay commented Feb 2, 2025

Example:

use syn::parse::{ParseBuffer, ParseStream, Result};
use syn::token::{Brace, Bracket, Paren};
use syn::{braced, bracketed, parenthesized, MacroDelimiter};

fn parse(input: ParseStream) -> Result<()> {
    let (_delim, _content) = input.call(macro_delimiter)?;
    Ok(())
}

fn macro_delimiter<'a>(input: ParseStream<'a>) -> Result<(MacroDelimiter, ParseBuffer<'a>)> {
    let content;
    let lookahead = input.lookahead1();
    let delim = if input.peek(Paren) {
        MacroDelimiter::Paren(parenthesized!(content in input))
    } else if input.peek(Brace) {
        MacroDelimiter::Brace(braced!(content in input))
    } else if input.peek(Bracket) {
        MacroDelimiter::Bracket(bracketed!(content in input))
    } else {
        return Err(lookahead.error());
    };
    Ok((delim, content))
}

Before:

error[E0308]: mismatched types
   --> src/main.rs:6:41
    |
6   |     let (_delim, _content) = input.call(macro_delimiter)?;
    |                                    ---- ^^^^^^^^^^^^^^^ one type is more general than the other
    |                                    |
    |                                    arguments to this method are incorrect
    |
    = note: expected fn pointer `for<'a> fn(&'a ParseBuffer<'a>) -> Result<_, _>`
                  found fn item `for<'a> fn(&'a ParseBuffer<'a>) -> Result<(MacroDelimiter, ParseBuffer<'a>), _> {macro_delimiter}`
note: method defined here
   --> syn/src/parse.rs:505:12
    |
505 |     pub fn call<T>(&self, function: fn(ParseStream) -> Result<T>) -> Result<T> {
    |            ^^^^

After: works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant