Use dep: and optional dependency feature ? syntax#1608
Merged
dtolnay merged 4 commits intodtolnay:masterfrom Mar 30, 2024
BD103:deps-features
Merged
Use dep: and optional dependency feature ? syntax#1608dtolnay merged 4 commits intodtolnay:masterfrom BD103:deps-features
dep: and optional dependency feature ? syntax#1608dtolnay merged 4 commits intodtolnay:masterfrom
BD103:deps-features
Conversation
This syntax needs Rust 1.60, so it will require a MSRV bump. If this is not wanted, I would be willing to revert it.
This change is using 6e8a372 for reference. I'm not entirely sure what the purpost of `manifestpath` was, so I may have done something incorrect.
dtolnay
approved these changes
Mar 30, 2024
Contributor
Author
|
Thank you! (That was fast 😄) |
Owner
|
Published in 2.0.57. |
This was referenced Mar 30, 2024
|
Just a heads up that the MSRV bump broke zerocopy: google/zerocopy#1085. I know that there's no ecosystem consensus on whether MSRV bumps should be considered breaking changes; just wanted to provide a data point. If syn's MSRV policy is to not consider MSRV bumps to be breaking changes, it'd be great if that were documented somewhere so we'd know to be aware of the risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes in 2 parts:
The first uses the
dep:syntax for theprintingfeature depending onquote, which removes the unused implicit feature.The second uses the
?syntax in theproc-macrofeature, soquoteis not pulled in as a dependency ifprintingis not enabled.Unfortunately, both of these changes raise the MSRV back to 1.60. Before finishing my changes in CI, I wanted to confirm that this was fine.