Skip to content

Check valid punctuation character in Punct::new#471

Merged
dtolnay merged 1 commit intomasterfrom
punctnew
Oct 7, 2024
Merged

Check valid punctuation character in Punct::new#471
dtolnay merged 1 commit intomasterfrom
punctnew

Conversation

@dtolnay
Copy link
Copy Markdown
Owner

@dtolnay dtolnay commented Oct 7, 2024

Closes #470.

Valid punctuation characters generated by:

use proc_macro::{Punct, Spacing, TokenStream};
use std::panic;

#[proc_macro]
pub fn punct_chars(_input: TokenStream) -> TokenStream {
    for ch in '\0'..=char::MAX {
        if let Ok(_) = panic::catch_unwind(|| {
            let _ = Punct::new(ch, Spacing::Alone);
        }) {
            eprintln!("{:?}", ch);
        }
    }
    TokenStream::new()
}

Valid punctuation characters generated by:

    use proc_macro::{Punct, Spacing, TokenStream};
    use std::panic;

    #[proc_macro]
    pub fn punct_chars(_input: TokenStream) -> TokenStream {
        for ch in '\0'..=char::MAX {
            if let Ok(_) = panic::catch_unwind(|| {
                let _ = Punct::new(ch, Spacing::Alone);
            }) {
                eprintln!("{:?}", ch);
            }
        }
        TokenStream::new()
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Punct::new() docs promise a panic on invalid punctuation character, but no panic actually ever happens making it possible to create an invalid Punct

2 participants