Merged
Conversation
Member
Author
|
@huangzhhui @kids-return 这里我有一些不太确定的点,就是 DtmMiddleware 里面,针对 GRPC 的处理是否合理,还有兼容 hyperf2.2 版本直接使用 class_map 替换了原有的 GRPC 的东西是否合理 |
Member
Author
|
不过我想了一下,如果真的要提供 GRPC 的这种 class_map 是不是由使用者自己配置会更好 |
Member
|
用 ClassMap 的目的是啥呢? |
Member
Author
hyperf/hyperf#5036 和这个PR有点关系,因为 hyperf2.2 里面 GRPC 协议实现上有点问题,statusCode 以及 Http Code 没有按照 GRPC 规范来使用,在 GRPC 通讯上是会有问题的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.