Skip to content

Fix barrier call#39

Merged
PandaLIU-1111 merged 9 commits intodtm-php:masterfrom
PandaLIU-1111:fix_barrier_call
Aug 25, 2022
Merged

Fix barrier call#39
PandaLIU-1111 merged 9 commits intodtm-php:masterfrom
PandaLIU-1111:fix_barrier_call

Conversation

@PandaLIU-1111
Copy link
Member

No description provided.

@PandaLIU-1111
Copy link
Member Author

@huangzhhui @kids-return 这里我有一些不太确定的点,就是 DtmMiddleware 里面,针对 GRPC 的处理是否合理,还有兼容 hyperf2.2 版本直接使用 class_map 替换了原有的 GRPC 的东西是否合理

@PandaLIU-1111
Copy link
Member Author

不过我想了一下,如果真的要提供 GRPC 的这种 class_map 是不是由使用者自己配置会更好

@huangzhhui
Copy link
Member

用 ClassMap 的目的是啥呢?

@PandaLIU-1111
Copy link
Member Author

用 ClassMap 的目的是啥呢?

hyperf/hyperf#5036 和这个PR有点关系,因为 hyperf2.2 里面 GRPC 协议实现上有点问题,statusCode 以及 Http Code 没有按照 GRPC 规范来使用,在 GRPC 通讯上是会有问题的

@PandaLIU-1111 PandaLIU-1111 merged commit 90f29a8 into dtm-php:master Aug 25, 2022
@PandaLIU-1111 PandaLIU-1111 deleted the fix_barrier_call branch August 25, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants