Skip to content

Added the option to change resolution based on an aspect ratio and target megapixel count#23

Merged
FransBouma merged 2 commits intodtgDTGdtg:masterfrom
etra0:feature/res-from-mpx
Nov 17, 2020
Merged

Added the option to change resolution based on an aspect ratio and target megapixel count#23
FransBouma merged 2 commits intodtgDTGdtg:masterfrom
etra0:feature/res-from-mpx

Conversation

@etra0
Copy link

@etra0 etra0 commented Nov 10, 2020

This PR adds a feature to change the resolution based on a target aspect ratio & megapixels. It adds a preview of the final resolution before setting it in order to avoid awkward situations.

Preview:
imagen

@etra0 etra0 force-pushed the feature/res-from-mpx branch 2 times, most recently from c1f418b to 29cfa3c Compare November 10, 2020 05:05
@etra0 etra0 marked this pull request as ready for review November 10, 2020 05:08
@etra0 etra0 marked this pull request as draft November 10, 2020 15:22
@etra0 etra0 force-pushed the feature/res-from-mpx branch from 29cfa3c to 6c3d831 Compare November 10, 2020 15:24
@etra0 etra0 force-pushed the feature/res-from-mpx branch from 6c3d831 to 07d5b77 Compare November 10, 2020 15:33
@etra0 etra0 marked this pull request as ready for review November 10, 2020 15:34
@FransBouma FransBouma merged commit 30c6556 into dtgDTGdtg:master Nov 17, 2020
@FransBouma
Copy link
Collaborator

FransBouma commented Nov 17, 2020

Thanks! I'll clean it up a bit by adding some {} around the if statements and will then release a new binary :)

(edit) the original code also doesn't have {} around the if statements, so I'll leave them at that :P

@FransBouma
Copy link
Collaborator

FransBouma commented Nov 17, 2020

Specifying a 0.5 in Scale sets it to 5x instead of 0.5x the size :) Will correct that. Will also check about the timer not ruining what one has typed in with width/height

(edit) ah, the 0.5 is seen as '5' as my regional settings are set to 'Dutch' which has ',' as fragment separator, not '.'.... I think there's a fix for that in tryparse, will see.

@etra0
Copy link
Author

etra0 commented Nov 17, 2020

Specifying a 0.5 in Scale sets it to 5x instead of 0.5x the size :) Will correct that. Will also check about the timer not ruining what one has typed in with width/height

(edit) ah, the 0.5 is seen as '5' as my regional settings are set to 'Dutch' which has ',' as fragment separator, not '.'.... I think there's a fix for that in tryparse, will see.

Sorry for the late reply, but yeah, the parse function seems to use the regional separator. For me it was the comma as well. Thanks for looking at those two details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants