fix: wait for draft issues to populate in copy project#53
Merged
dsanders11 merged 1 commit intomainfrom Mar 5, 2025
Merged
Conversation
There was a problem hiding this comment.
PR Overview
This PR addresses an asynchronous delay in populating draft issues when copying a project by implementing a polling mechanism that waits for the draft issues to fully populate before proceeding with template interpolation.
- Introduces a wait loop in copy-project.ts to poll for draft issue completion using the new getProject API.
- Updates tests to mock the new getProject function appropriately.
Reviewed Changes
| File | Description |
|---|---|
| src/copy-project.ts | Implements a polling mechanism to wait for draft issues to populate. |
| tests/copy-project.test.mts | Updates tests to provide proper mocks for the new getProject API. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/copy-project.ts:86
- [nitpick] Consider extracting the loop limit '10' into a named constant to improve readability and ease future adjustments.
for (let i = 0; i < 10; i++) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something has changed on the GitHub side and now when copying a project it appears draft issues populate in an async manner so we need to wait for them before continuing with interpolation.