Skip to content

fix: handle redacted items on project#46

Merged
dsanders11 merged 1 commit intomainfrom
fix/handle-redacted-items
Jan 22, 2025
Merged

fix: handle redacted items on project#46
dsanders11 merged 1 commit intomainfrom
fix/handle-redacted-items

Conversation

@dsanders11
Copy link
Owner

Issues transferred to private repos will show up on the project as redacted items, which have no content available. Properly handle this case.

@dsanders11 dsanders11 force-pushed the fix/handle-redacted-items branch from e9aab25 to d076c40 Compare January 22, 2025 05:21
@dsanders11 dsanders11 marked this pull request as ready for review January 22, 2025 05:32
@dsanders11 dsanders11 requested a review from Copilot January 22, 2025 05:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 21 out of 26 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • tests/delete-project.test.mts: Evaluated as low risk
  • tests/get-item.test.mts: Evaluated as low risk
  • src/get-item.ts: Evaluated as low risk
  • src/edit-item.ts: Evaluated as low risk
  • tests/copy-project.test.mts: Evaluated as low risk
Comments suppressed due to low confidence (3)

tests/lib.test.ts:450

  • The assertion should check the exact arguments passed to execCliCommand for stronger validation.
expect(execCliCommand).toHaveBeenCalledWith(expect.arrayContaining([owner, projectNumber]));

tests/lib.test.ts:1046

  • Ensure that the tests cover the new structure properly, especially since the __typename property has been removed.
const { content, type } = items[0];

tests/edit-item.test.mts:170

  • [nitpick] The error message 'Cannot edit redacted items' could be more descriptive. Consider changing it to 'Cannot edit items that have been redacted due to privacy or security reasons'.
Cannot edit redacted items

@dsanders11 dsanders11 force-pushed the fix/handle-redacted-items branch from d076c40 to b73960e Compare January 22, 2025 05:55
@dsanders11 dsanders11 merged commit 9c80cd3 into main Jan 22, 2025
5 checks passed
@dsanders11 dsanders11 deleted the fix/handle-redacted-items branch January 22, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants