fix: add support for binary files#20
Conversation
|
Hi @marcus-bcl, thanks for the PR! I'll try to give this a more thorough review later in the week, but I have some initial questions after a quick glance.
|
|
Realized this issue is going to bite my usage as well soon (thanks for pointing it out!), so I made some time to dig into it more. In my testing just base64-encoding all content going to I made a branch with a more concise version of your changes in this PR, with an integration test that I've confirmed fails without the code change and passes with it. Could you verify it works for your use case? Should be able to use it with |
That's great, your version looks much simpler. I'll give it a try today and let you know, thank you! |
|
@dsanders11 I've tested from your branch and all looks good. Here's an example of the JAR file that was uploaded before, which doesn't run and fails checksum validation: gradle/wrapper/gradle-wrapper.jar And here's the JAR file that was uploaded using your branch, which works as expected: gradle/wrapper/gradle-wrapper.jar Thanks again! |
|
Merged that branch and it's released now as v1.4.1, thanks again! |
This pull requests adds support for files that are not UTF8-encoded - for example JAR files. Previously these would be corrupted on upload.
Inspiration taken from google/go-github#1293 and https://github.com/maticzav/github-tree.