Add a metrics-jackson3 module - metrics-json but dependent on jackson 3#5101
Merged
joschi merged 1 commit intodropwizard:release/4.2.xfrom Jan 15, 2026
Merged
Add a metrics-jackson3 module - metrics-json but dependent on jackson 3#5101joschi merged 1 commit intodropwizard:release/4.2.xfrom
joschi merged 1 commit intodropwizard:release/4.2.xfrom
Conversation
Closed
Contributor
Author
|
@joschi I think the JDK11 build is failing because the baseline JDK for Jackson 3 is 17 - should I add a profile here to enable/disable the module based on JDK building it? |
joschi
reviewed
Jan 14, 2026
Member
There was a problem hiding this comment.
issue: Jackson 3.x is using JDK 17 as its baseline, so the module needs to be excluded from builds with lower JDK versions.
Take a look at the metrics-jetty12 module for an example how to do this.
Member
@cunningt Yes, please. See my comment in the code. 😄 |
joschi
approved these changes
Jan 15, 2026
Member
|
@cunningt Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5100
https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md
Add a metrics-jackson3 module (metrics-json but dependent on jackson 3 and with the API changes required by jackson 3 migration). PR builds cleanly on my machine, the two tests in metrics-jackson3 pass.
I see two untracked files after building (metrics-benchmarks/dependency-reduced-pom.xml, metrics-jcstress/dependency-reduced-pom.xml) but I don't see them checked into 4.2.x branch. Should I add them? Should dependency-reduced-pom.xml be added to .gitignore?