Skip to content

Conversation

@rhowe
Copy link
Contributor

@rhowe rhowe commented Jul 24, 2025

Newer releases of mockito added support for embedding test assertions in verify statements, which means we don't always need to use ArgumentCaptor.

@rhowe rhowe requested a review from a team as a code owner July 24, 2025 06:12
@github-actions github-actions bot added this to the 4.0.15 milestone Jul 24, 2025
@joschi joschi modified the milestones: 4.0.15, 4.0.16 Jul 24, 2025
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhowe Could you please use explicit imports instead of wildcard imports?

Otherwise this looks good to me.

@rhowe
Copy link
Contributor Author

rhowe commented Aug 19, 2025

@rhowe Could you please use explicit imports instead of wildcard imports?

Otherwise this looks good to me.

Sure, will amend. I blame IntelliJ here!

@rhowe rhowe force-pushed the mockito-assertarg branch from 34a5d11 to fdeed8e Compare August 19, 2025 22:24
Newer releases of mockito added support for embedding test assertions in
verify statements, which means we don't always need to use
ArgumentCaptor.
@rhowe rhowe force-pushed the mockito-assertarg branch from fdeed8e to b032b3e Compare August 19, 2025 22:31
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhowe Thanks!

@joschi joschi enabled auto-merge (squash) August 19, 2025 22:52
@joschi joschi merged commit 33273cc into dropwizard:release/4.0.x Aug 19, 2025
10 of 11 checks passed
@rhowe rhowe deleted the mockito-assertarg branch August 20, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants