Add feature for adding keys by environment variables#107
Add feature for adding keys by environment variables#107diwakergupta merged 1 commit intodropbox:masterfrom
Conversation
|
@diwakergupta Please review my PR. |
diwakergupta
left a comment
There was a problem hiding this comment.
Unfortunately this breaks the current build system for dbxcli -- see how credentials are supplied at build-time via build.sh. Can you move updating all these to init instead?
|
@diwakergupta I have made the requested changes, now the keys can be accessed through env variables without build failure in official release. Please review my PR. |
|
Thanks for adding this feature! I've looked over the changes and also the code in I'm still a little confused though. Is it possible to continue to use the default app keys (i.e. not create my own dropbox app) and then use either the web authentication response or the data from the I've tried it with both |
Fixes #104 .