Skip to content

Switch to pyproject.toml-based build#324

Merged
jayqi merged 11 commits intomasterfrom
pyproject-toml-build
Feb 28, 2023
Merged

Switch to pyproject.toml-based build#324
jayqi merged 11 commits intomasterfrom
pyproject-toml-build

Conversation

@jayqi
Copy link
Copy Markdown
Member

@jayqi jayqi commented Feb 24, 2023 •
edited
Loading

Switches to pyproject.toml-based build. We had been using deprecated setuptools build and install commands, and this is a good opportunity to also switch from setup.py to the modern build standards.

Bonuses:

  • Add a badge that links to the cloudpathlib conda-forge feedstock
  • Switch notify failed build to jayqi/failed-build-issue-action which will append new notifications as comments to most recent existing open issue if one exists
  • Bump action/checkout, remaining action/setup-python@v2, and nwtgck/actions-netlify as the old versions that use the node12 runtime are deprecated

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-324--gallant-agnesi-5f7bb3.netlify.app

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2023 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.3%. Comparing base (fa3a4f2) to head (c25c46a).
Report is 66 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #324     +/-   ##
========================================
- Coverage    94.5%   94.3%   -0.2%     
========================================
  Files          22      22             
  Lines        1463    1463             
========================================
- Hits         1383    1381      -2     
- Misses         80      82      +2

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayqi jayqi requested a review from pjbull February 24, 2023 19:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2023

🚀 Deployed on https://deploy-preview-324--gallant-agnesi-5f7bb3.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 24, 2023 19:45 Inactive
pjbull
pjbull approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pjbull pjbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jayqi jayqi merged commit a0dd927 into master Feb 28, 2023
@jayqi jayqi deleted the pyproject-toml-build branch February 28, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjbull pjbull pjbull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jayqi @codecov-commenter @pjbull