fix: sync main into develop for clean release#205
Conversation
## Summary Post-merge fixes addressing all review findings from PR #194, plus CI failures and additional improvements. ### Security - Fix YAML frontmatter escaping (backslashes, control chars) — CodeQL critical - Validate plugin IDs with regex + path traversal check - Fix PowerShell path interpolation (separate args) - Add 50MB size limit + tmpDir cleanup in finally for plugin install - HTML-escape table cell content in clipboard export - Validate installFromUrl slug matches manifest.id - HTTPS-only validation in preload for plugin URLs - Enforce minimum 100k PBKDF2 iterations in encryption service ### CI Fixes - Fix mcp-server TS2532 from noUncheckedIndexedAccess - Restructure ESLint: type-aware rules only for src/ files in tsconfig projects (0 errors) - ci.yml: add contents:read permission to label job ### Accessibility - `aria-pressed` on filter pills, `useId()` for modal, conditional toast role - Auto-focus primary button in welcome dialog ### UX - Save indicator no longer flashes on note switch - UpdateBanner shows error messages with retry - SidebarFooter "Synced Xm ago" display - Error toasts on failed plugin install/uninstall - Marketplace API response validation ### Code Quality - Async clipboard handlers, Unicode-safe filenames - CSS camelCase consistency, danger hover tokens via color-mix - Stricter semver regex, .env.example formatting ## Test plan - [x] `pnpm typecheck` — 17/17 pass - [x] `pnpm test` — 16/16 pass - [x] `pnpm lint` — 0 errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ease # Conflicts: # apps/desktop/src/main/index.ts # apps/desktop/src/renderer/components/UpdateBanner.tsx # apps/desktop/src/renderer/pages/settings/sections/PluginsSection.tsx # apps/desktop/src/renderer/pages/settings/sections/Section.module.css # apps/desktop/src/renderer/ui/patterns/Modal.tsx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 44 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Merges main into develop to resolve all conflicts so PR #202 (release) can merge cleanly.
All 5 conflicts resolved keeping develop's version (which has all review fixes from PRs #199-#204).
Test plan
pnpm typecheck— 17/17 pass🤖 Generated with Claude Code