[improve] [broker] PIP-307 Consumer#1
Closed
dragosvictor wants to merge 26 commits into
Closed
Conversation
heesung-sohn
reviewed
Nov 9, 2023
| producers.values().forEach(producer -> futures.add(producer.disconnect(lookupData))) | ||
| brokerService.getPulsar(), topic).thenAccept(lookupData -> { | ||
| producers.values().forEach(producer -> futures.add(producer.disconnect(lookupData))); | ||
| subscriptions.forEach((s, sub) -> futures.add(sub.disconnect(lookupData))); |
There was a problem hiding this comment.
We need to confirm the dispatching behavior when we close the topic with disconnectClients=false.
I think our expectation is to stop dispatching messages to consumers when the ledger is fenced. Could we confirm if this happens correctly? (also we probably want to add some metrics to show dispatcher pause time too. This can be a separate PR too.)
1a66397 to
9af35e1
Compare
9af35e1 to
4de3a4d
Compare
4de3a4d to
d2ba22f
Compare
15 tasks
…n.disconnect methods
…trySendMessagesToConsumers
…rsistentTest#cumulativePendingAckReplayTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: PIP-307
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: