Conversation
|
assuming folks approve this i'll write docs for it, and then should be ready to merge |
|
The implementation here all looks good to me, although I might bikeshed a bit on the name. Perhaps something like Also as a future-compatible note, this will probably want to generate a hard error if a Rust crate depends on an NPM package (e.g. when the npm dependencies implementation lands here if that is combined with |
|
@alexcrichton yeah i thought about a manifest related type name, i'm happy to do that if i am understanding the ask, i actually imagine the end user would want a package.json... it'd be necessary. we could still skip the cargo.toml serialization and the readme and license steps.. this convo might be best on the npm feature tracking issue tho |
|
tho.. if we would eventually with npm feature support make a packagejson for this no pack flag... that makes the name more confusing. |
|
i am waiting to sync up with @Pauan but i think we should probably just close this. when considered with the npm feature, this feature does not really make sense.
|
|
+1 for |
fitzgen
left a comment
There was a problem hiding this comment.
Code looks good to me; will let the naming and npm deps play out.
There was a problem hiding this comment.
Tried and it works. I would like to suggest skipping .gitignore too.
Additionally generating TS could be disabled by default when passing --no-pack in my opinion, maybe additionally check for --target web to do that.
I can do the rebase to if it helps @ashleygwilliams.
Code looks good to me; will let the naming and npm deps play out.
Is this blocked on #691 or not?
| } | ||
|
|
||
| fn get_process_steps(mode: InstallMode) -> Vec<(&'static str, BuildStep)> { | ||
| fn get_process_steps(mode: InstallMode, no_pack: bool) -> Vec<(&'static str, BuildStep)> { |
There was a problem hiding this comment.
| fn get_process_steps(mode: InstallMode, no_pack: bool) -> Vec<(&'static str, BuildStep)> { | |
| fn get_process_steps(&self) -> Vec<(&'static str, BuildStep)> { |
Would give it access to both without having to pass any parameters at all.
|
Any progress? |
fixes #691
adds a flag
--no-packwhich will skip 3 steps: