[Relocatable] Follow-up 13: coreboot without all the stripping#215
Open
dra27 wants to merge 3 commits intorelocatable-testingfrom
Open
[Relocatable] Follow-up 13: coreboot without all the stripping#215dra27 wants to merge 3 commits intorelocatable-testingfrom
dra27 wants to merge 3 commits intorelocatable-testingfrom
Conversation
88186bc to
3c8b5c1
Compare
3c8b5c1 to
2a7e0ad
Compare
b3d9d76 to
566e0e9
Compare
566e0e9 to
48ae3e8
Compare
48ae3e8 to
dbd40e4
Compare
dbd40e4 to
6176302
Compare
d644c59 to
63922b2
Compare
6176302 to
2df5204
Compare
63922b2 to
198fcfd
Compare
2df5204 to
7f12fde
Compare
198fcfd to
56b115d
Compare
7f12fde to
26a6c6b
Compare
All the functions in Meta are now only required by the toplevel, however two of them are still quite tangled up with Symtable. Begin the process of disentanglement by moving those two functions to Symtable and the remaining ones directly to the bytecode toplevel (Dynlink already has its own implementations).
Bytecode images (including for -output-obj) now only include the CRCS section if the image actually needs dynamic loading (which is identified by the use of the caml_reify_bytecode primitive which is only used by the toplevel and dynlink).
In order to be repeatable, the coreboot cycle routinely has to relink both boot artefacts with a fixed configuration. It's not therefore much more of a stretch to link those artefacts with the required flags to suppress both the header (and RNTM section, if applicable) and debugging information. Combined with the previous change to suppress CRCS when the image doesn't use dynamic loading, the coreboot cycle can be accomplished without having to post-process the artefacts with stripdebug.
56b115d to
5c4d9f3
Compare
26a6c6b to
d3e26bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.