[Relocatable] Follow-up 11: Add -set-runtime-default to the compilers#186
Open
dra27 wants to merge 7 commits intorelocatable-testingfrom
Open
[Relocatable] Follow-up 11: Add -set-runtime-default to the compilers#186dra27 wants to merge 7 commits intorelocatable-testingfrom
-set-runtime-default to the compilers#186dra27 wants to merge 7 commits intorelocatable-testingfrom
Conversation
b1385df to
f24a3f4
Compare
cf7bb12 to
a300876
Compare
f24a3f4 to
27ddeab
Compare
a300876 to
b840f43
Compare
27ddeab to
29ffd73
Compare
b840f43 to
12a6760
Compare
d2b47e7 to
2cca80a
Compare
12a6760 to
9312be2
Compare
2cca80a to
8df52ed
Compare
94e431b to
85ea65d
Compare
de87814 to
7fe9197
Compare
1ff8aae to
3adcf49
Compare
7fe9197 to
3ba7282
Compare
08e6e34 to
ef7bedc
Compare
ada9ed4 to
27ee9a7
Compare
3ba7282 to
3a26b71
Compare
27ee9a7 to
c602311
Compare
3a26b71 to
f6477de
Compare
c602311 to
ec86560
Compare
f6477de to
dd10014
Compare
2488f9b to
299ae51
Compare
dd10014 to
59ef79e
Compare
299ae51 to
2bf8a73
Compare
They are only used by the bytecode runtime and can be made static to startup_byt.
The setting for R was previous omitted in Sys.runtime_parameters, since it was only processed directly by the Hashtbl module and not stored in the runtime. Option R is now processed in caml_parase_ocamlrunparam and stored to be accessed and updated via new primitives for the Hashtbl module. Co-authored-by: David Allsopp <david.allsopp@metastack.com>
Consistency - options displayed in alphabetical order with the uppercase letter appearing before the lowercase letter
When linking an executable, allows to set default to OCAMLRUNPARAM values. This new OCAMLRUNPARAM string is accessible using the "caml_executable_ocamlrunparam" symbol or is embedded in a bytecode section. Co-authored-by: Antonin Décimo <antonin@tarides.com>
The test programs in the run after the prefix has been renamed are compiled with `-set-runtime-default R`, and the test program verifies that Hashtbl.is_randomized returns the expected value.
In bytecode startup, defer allocating memory until after the bytecode image has been loaded as far as possible.
The runtime's pooling mode has a slight Catch-22 problem for ocamlrun when enabled using -set-runtime-default. Opening the bytecode file and reading the ORUN section requires the memory subsystem. In this revised version, caml_main in bytecode is particularly careful to track exactly what will have been allocated prior to reading the ORUN section and if ORUN requires the system to start pooling mode, the runtime now takes temporary malloc'd copies of everything which has been made so far so that it can be safely copied with a caml_stat_alloc _after_ pooling mode has been enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.