[Relocatable] Follow-up 23: Dynlink-related tidying following ld.conf changes#185
Open
dra27 wants to merge 1 commit intorelocatable-testingfrom
Open
[Relocatable] Follow-up 23: Dynlink-related tidying following ld.conf changes#185dra27 wants to merge 1 commit intorelocatable-testingfrom
dra27 wants to merge 1 commit intorelocatable-testingfrom
Conversation
8538cf3 to
cf7bb12
Compare
763d509 to
9ce6bf3
Compare
cf7bb12 to
a300876
Compare
9ce6bf3 to
f8ea04d
Compare
a300876 to
b840f43
Compare
f8ea04d to
5d152fd
Compare
b840f43 to
12a6760
Compare
5d152fd to
074d279
Compare
12a6760 to
9312be2
Compare
074d279 to
f82fe48
Compare
85ea65d to
7d2a2d9
Compare
f82fe48 to
7c13803
Compare
7d2a2d9 to
d1a72a0
Compare
7c13803 to
302bce4
Compare
d1a72a0 to
b5d5bb8
Compare
302bce4 to
f9fd408
Compare
b5d5bb8 to
8ad918d
Compare
1ff8aae to
3adcf49
Compare
08e6e34 to
ef7bedc
Compare
ada9ed4 to
27ee9a7
Compare
27ee9a7 to
c602311
Compare
c602311 to
ec86560
Compare
2488f9b to
299ae51
Compare
299ae51 to
2bf8a73
Compare
2bf8a73 to
92bf763
Compare
f2d5bf1 to
3c43f64
Compare
7c36266 to
5d3eea2
Compare
In the debug runtime, caml_prim_name_table remains for the lifetime of the program, as it's used by instrtrace.c, but in normal operation, once the list of primitives has been handed over to Dynlink, it's no longer required. In the normal runtime, it's now freed after this handover. In passing, strings themselves are no longer duplicated, as the code path is a good deal simpler than it used to be, and the bytecode section itself can reliably be used as the underlying buffer for caml_prim_name_table. caml_shared_libs_path is only kept at all to be handed over to Dynlink. It, along with the two underlying buffers for CAML_LD_LIBRARY_PATH and ld.conf are freed after the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.