fix: use original URL for plugin type detection after redirect#1121
Merged
dsherret merged 2 commits intoApr 1, 2026
Merged
Conversation
PR dprint#1114 changed plugin_kind() to check the resolved (post-redirect) URL instead of the original source URL. GitHub Releases redirects .wasm URLs to a CDN URL (release-assets.githubusercontent.com/...) that does not end in .wasm, causing plugin_kind() to return None and reject the plugin. Fix: pass both the original source (for type detection) and the resolved source (for relative URL resolution in process plugins) to setup_plugin. Fixes dprint#1120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1114 changed plugin_kind() to check the resolved (post-redirect) URL instead of the original source URL. GitHub Releases redirects .wasm URLs to a CDN URL (release-assets.githubusercontent.com/...) that does not end in .wasm, causing plugin_kind() to return None and reject the plugin.
Fix: pass both the original source (for type detection) and the resolved source (for relative URL resolution in process plugins) to setup_plugin.
Fixes #1120