Use InvalidMessageException and add test#2
Merged
Conversation
…`ByteBifferMessageSet`
2705522 to
dedd599
Compare
|
LGTM. |
Author
There was a problem hiding this comment.
Just noticed a typo in this method name. Will fix it.
dedd599 to
7733f28
Compare
|
The patch LGTM. It's a bit weird that Errors and ErrorMapping map error code 2 to different exception names. Perhaps we can add a comment in InvalidMessageException that when we phase out the old scala clients, we can replace InvalidMessageException with CorruptRecordException. |
Author
|
@junrao We kind of say that already: * InvalidMessageException extends CorruptRecordException for temporary compatibility with the old Scala clients. |
Author
|
But perhaps that could be made clearer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.